Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threads to run arbitrary hoon #6336

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

ashelkovnykov
Copy link
Contributor

Related to #197 in urbit/vere.

This PR introduces threads which will be useful to any conn.c client. More specifically, these threads will be specifically targeted by the thin and thick clients I plan to produce for the issue linked above.

belisarius222
belisarius222 previously approved these changes Feb 17, 2023
Copy link

@belisarius222 belisarius222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the long run, we'd be better off having this take in a Ford source file that would be parsed to a $pile and then built according to the standard Ford build semantics, to allow reuse of Ford runes and recursive imports. As far as I can tell, there's nothing wrong with this as it is, though.

@ashelkovnykov
Copy link
Contributor Author

I plan to implement @belisarius222's feedback later in a separate PR.

I originally opened this PR as a draft because I thought I might change the threads slightly while working on the client which uses them. It seems like there's already demand for these threads, so I'll mark this as a regular PR and makes changes in a separate PR.

I'll also move the hoon.hoon style fixes to a separate PR so that this one doesn't force a %base recompile.

@belisarius222 belisarius222 merged commit 51be666 into urbit:develop Feb 17, 2023
@ashelkovnykov ashelkovnykov deleted the eval-ted branch February 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants